Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flux] Port Flux Core Model #1864

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

DavidLandup0
Copy link
Collaborator

@DavidLandup0 DavidLandup0 commented Sep 23, 2024

Draft PR for observability.

Ports the core model into a Keras model.
VAE and rest of the pipeline would make sense in a separate PR.

Notebook with numerical comparisons of modules: https://colab.research.google.com/drive/1TUI2outgEXA1-dczw4SU8i6z_7oj4CGu?usp=sharing

Includes:

  • Maths module
    • Timestep embedding
    • RoPE
    • Attention
    • Scaled dot product attention re-implementation in Keras (to match the PyTorch one)
  • Layers module
    • MLPEmbedder
    • RMSNorm
    • QKNorm
    • SelfAttention
    • Modulation
    • DoubleStreamBlock
    • SingleStreamBlock

TODO:

  • Combine components into model
  • Expand on documentation
  • Verify all components having numerically equivalent behavior through demo notebook

@sachinprasadhs sachinprasadhs marked this pull request as draft September 23, 2024 16:51
@DavidLandup0 DavidLandup0 changed the title [Flux] Port Flux Model and Pipeline [Flux] Port Flux Core Model Oct 2, 2024
@DavidLandup0 DavidLandup0 marked this pull request as ready for review October 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant